Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rust toolchain repositories from custom repo rules #1036

Merged
merged 5 commits into from
Nov 29, 2021
Merged

Allow rust toolchain repositories from custom repo rules #1036

merged 5 commits into from
Nov 29, 2021

Conversation

ikalchev
Copy link
Contributor

This change allows crate_universe to use a custom repo for the rust toolchain. I.e. suppose that cargo and rustc come from a custom repo rule and have different paths inside the repo rule (compared to the standard "upstream")

Fixes #1019

@google-cla google-cla bot added the cla: yes label Nov 25, 2021
illicitonion
illicitonion approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit dc66c16 into bazelbuild:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow rust toolchain repositories from custom repo rules
2 participants
@ikalchev @illicitonion